Conversation
mateusz834
force-pushed
the
dev/MP/deflake-collection
branch
2 times, most recently
from
8e75140 to
719f4c2
Compare
cecyliaborek
approved these changes
Aug 19, 2025
Contributor
cecyliaborek
left a comment
cecyliaborek
left a comment
There was a problem hiding this comment.
makes sense to me 👌
mateusz834
force-pushed
the
dev/MP/deflake-collection
branch
2 times, most recently
from
635415e to
3fde468
Compare
Current tests perform read operations twice and assert based on previous results. This approach is inherently flaky because some background operations in Splunk can modify data between reads. This change, wraps every test case in assertEventuallyTrue.
mateusz834
force-pushed
the
dev/MP/deflake-collection
branch
from
3fde468 to
a12f605
Compare
Collaborator
|
(mistakenly removed the branch in git) |
Ickerday
approved these changes
Aug 19, 2025
Ickerday
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current tests perform read operations twice and assert based on previous results. This approach is inherently flaky because some background operations in Splunk can modify data between reads.
This change, wraps every test case in assertEventuallyTrue.